Adding .fog.example and amending docs #207
Conversation
README.md
Outdated
| @@ -76,6 +76,8 @@ my_credential: | |||
| google_json_key_location: /path/to/my-project-xxxxxxxxxxxx.json | |||
| ``` | |||
|
|
|||
| Or simply `cat .fog.example >> ~.fog` and edit parameters in the file. | |||
There was a problem hiding this comment.
~.fog is an incorrect glob, as it'll resolve to: /Users/myuser.fog, you need a slash: ~/.fog
.fog.example
Outdated
| @@ -0,0 +1,12 @@ | |||
| ##################################################### | |||
| # This is configuration snippet to configure Google Cloud Platform | |||
| # for fig library. | |||
.fog.example
Outdated
| # 2. Follow instructions to generate a private key: | ||
| # https://cloud.google.com/storage/docs/authentication#generating-a-private-key | ||
|
|
||
| my_credential: |
There was a problem hiding this comment.
Although I do admit that's our doc issue, I'm not sure if my_credential will actually work by default if you didn't explicitly load them via Fog::Credentials. AFAIK only "default" works by default and whatever is in "test" is loaded by tests.
Have you tested this?
|
ACK on comments - thanks.
|
|
New commit which addresses Temikus comments: palladius@93781eb |
|
@palladius LGTM, thanks for contributing \o/ Sorry it took a while. One last note - I suggest setting your git config to a proper email, so you get the contribution tracked on github properly. Currently your commit's email is set to "[email protected]". Either associate that with GitHub or: Cheers! |
|
(You'll need to |
|
Thanks bros! Done the following: git rebase -i HEAD~2 |
|
Thanks! |
[trying my first pull request here! So apologies for newbbisities]
Adding a sample file for .fog and proposing in the docs to just append this sample into your home fog (I'm not an expert but I presume this is safer than a CP as people might have stuff already in there). Ideally if you like this idea I can actually remove the same stuff from README (more DRY) - but I wasnt sure.